Has anyone imported Custom Objects successfully?

rcheesley · August 10, 2022, 8:21am

Hey @joeyk @mzagmajster please review and test

github.com/mautic/mautic

Fix property must not be accessed before initialization error

mautic:5.x ← ts-navghane:fix-co-property-initialization-while-imports

opened 04:13AM - 10 Aug 22 UTC

ts-navghane

+2 -2

| Q | A | -------------------------------------- | --- | Bug fix? (use the a.b branch) | ✅ | New feature/enhancement? (use the a.x branch) | ❌ | Deprecations? | ❌ | BC breaks? (use the c.x branch) | ❌ | Automated tests included? | ❌ | Related user documentation PR URL | mautic/mautic-documentation#... | Related developer documentation PR URL | mautic/developer-documentation#... | Issue(s) addressed | Fixes Custom Objects Imports  #### Description:  Since PHP 7.4 introduces type-hinting for properties, it is particularly important to provide valid values for all properties, so that all properties have values that match their declared types. A property that has never been assigned doesn't have a null value, but it is on an uninitialized (undefined) state, which will never match any declared type (undefined !== null). #### Steps to test this PR:  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs [here](https://contribute.mautic.org/contributing-to-mautic/tester)) 2. Create custom object with some fields 3. Now, try to import a CSV with relevant fields for custom objects 4. Observe the "Property must not be accessed before initialization error" message in the logs before the PR is applied 5. After PR, you should be able to import CSV for custom objects  <a href="https://gitpod.io/#https://github.com/mautic/mautic/pull/11388"><img src="https://gitpod.io/button/open-in-gitpod.svg"/></a>

which should resolve this bug!

Topic		Replies	Views
Unable to read the imported csv file. Mastic 1.2.2 Product Support	6	564	February 2, 2020
Can't import a .csv file in Manage Leads Product Support	8	882	February 2, 2020
Error when importing lead Product Support	3	228	February 2, 2020
Import Contact: Unable to read the imported csv file. Product Support	10	2025	November 14, 2017
Mautic Import Frozen Product Support	1	536	November 12, 2019

Has anyone imported Custom Objects successfully?

Related topics