Nord
March 21, 2022, 9:39am
1
Your software
Your problem
These errors are showing in the log:
Testing:
Hi there,
Known issue, already fixed:
mautic:4.x ← CTMobi:alfredo-fix-segments-order
opened 10:44AM - 07 Mar 22 UTC
<!-- ## Which branch should I use for my PR?
Assuming that:
a = current ma… jor release
b = current minor release
c = future major release
* a.x for any features and enhancements (e.g. 4.x)
* a.b for any bug fixes (e.g. 4.0, 4.1, 4.2)
* c.x for any features, enhancements or bug fixes with backward compatibility breaking changes (e.g. 5.x) -->
| Q | A
| -------------------------------------- | ---
| Bug fix? (use the a.b branch) | yes
| New feature/enhancement? (use the a.x branch) | no
| Deprecations? | no
| BC breaks? (use the c.x branch) | no
| Automated tests included? | yes
| Related user documentation PR URL | mautic/mautic-documentation#...
| Related developer documentation PR URL | mautic/developer-documentation#...
| Issue(s) addressed | Fixes #10925
<!--
Additionally (see https://contribute.mautic.org/contributing-to-mautic/developer/code/pull-requests#work-on-your-pull-request):
- Always add tests and ensure they pass.
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against the "4.x" branch.
-->
#### Description:
This is a follow up of PR from @kuzmany ( https://github.com/mautic/mautic/pull/10862 ) and of my PRs for modify order columns.
It resolve issue #10925 , I noticed that on 4.x order of segments doesn't work on any column because the session being retrieved is different from the one being saved.
setListFilters method save session as 'lead.list', but session was retrieved as 'segment'
<!--
Please write a short README for your feature/bugfix. This will help people understand your PR and what it aims to do. If you are fixing a bug and if there is no linked issue already, please provide steps to reproduce the issue here.
-->
#### Steps to test this PR:
<!--
This part is really important. If you want your PR to be merged, take the time to write very clear, annotated and step by step test instructions. Do not assume any previous knowledge - testers may not be developers.
-->
1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs [here](https://contribute.mautic.org/contributing-to-mautic/tester))
2. Create two or more segments
3. Go to segments list page
4. Check if order is correct and try to click on the columns to change order
<!--
If you have any deprecations, list them here along with the new alternative.
If you have any backwards compatibility breaks, list them here.
-->
<a href="https://gitpod.io/#https://github.com/mautic/mautic/pull/10938"><img src="https://gitpod.io/button/open-in-gitpod.svg"/></a>