Titles on grapejs drag n drop section blocks need correcting in M5 rc1

techbill · November 28, 2023, 5:15pm

I am testing out Mautic 5 rc1 and I spotted the titles on some of the grapejs blocks need fixing / correcting.

Three of the block are showing grapejsbuilder as the title instead of 1 Column, 2 Columns, and 3 Columns.

See attached screenshot.

rcheesley · November 28, 2023, 5:34pm

Interesting, guessing some were missed on this PR:

github.com/mautic/mautic

Add translations for new blocks

mautic:4.4 ← volha-pivavarchyk:feature/add-translations-for-new-blocks

opened 10:17PM - 27 Mar 22 UTC

volha-pivavarchyk

+22 -2

| Q | A | -------------------------------------- | --- | Bug fix? (use the a.b branch) | [no ] | New feature/enhancement? (use the a.x branch) | [yes] | Deprecations? | [no ] | BC breaks? (use the c.x branch) | [no] | Automated tests included? | [no] | Related user documentation PR URL | mautic/mautic-documentation#... | Related developer documentation PR URL | mautic/developer-documentation#... | Issue(s) addressed | Fixes #...  #### Description: This PR adds translations for new blocks in the grapesjs builder. Related to the PR [#28](https://github.com/mautic/grapesjs-preset-mautic/pull/28)  #### Steps to test this PR: This PR can be tested after merging the PR [#28](https://github.com/mautic/grapesjs-preset-mautic/pull/28)  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs [here](https://contribute.mautic.org/contributing-to-mautic/tester)) 2. Create new mjml email or select an existing one 3. Open the grapesjs builder 4. Block titles here  <a href="https://gitpod.io/#https://github.com/mautic/mautic/pull/11006"><img src="https://gitpod.io/button/open-in-gitpod.svg"/></a>

Could you flag it as an issue on GitHub @techbill please?

techbill · November 28, 2023, 5:48pm

Flagged on Github - M5 grapejs drag n drop block missing titles in English language · Issue #12934 · mautic/mautic · GitHub

Topic		Replies	Views
Builder issues Product Support mautic-4	3	497	May 1, 2022
New builder labels broken (upgraded from V3) Product Support	7	322	January 4, 2022
At a loss with the GrapeJS builder Product Support	2	292	August 5, 2021
Imported MJML code breaks 3rd Party Addons	5	623	June 22, 2021
Custom mautic MJML email template builder bug Product Support mautic-4	4	549	February 23, 2024

Titles on grapejs drag n drop section blocks need correcting in M5 rc1

Related Topics