Has IP Lookup (e.g. maxmind) always overwritten location information? Any way to change this behavior?

steverobinson · December 12, 2019, 8:17pm

Your software
My Mautic version is: 2.15.3
My PHP version is: 7.2

I noticed today that the IP lookup service (Maxmind free, in this case) is overwriting the city and state on contacts in the database, even if there is another value in there.

This means if a contact has a valid mailiing address in the system and they engage with the website from a city/state that doesn’t match their street address, they end up with an invalid address in the database.

Has anyone figured out how to use IP lookup without completely hosing mailing addresses?

Yosu_Cadilla · December 13, 2019, 10:20am

I can’t reply to your specific question, but I’ve experienced data overwriting too with a Zapier integration via API, which would write over existing data.
Maybe something has changed in the way existing data is managed/protected?

kuzmany · December 13, 2019, 5:38pm

Couldn’t rewrite.
There is condition If exists any of address1, city, zip, state, country, then skip update these fields from GEO location database.

github.com

mautic/mautic/blob/4368fac19827a7aa08fac2f47f64070835c7a5e9/app/bundles/LeadBundle/Model/LeadModel.php#L509


public function saveEntity($entity, $unlock = true)
{
    $companyFieldMatches = [];
    $fields              = $entity->getFields();
    $company             = null;


    //check to see if we can glean information from ip address
    if (!$entity->imported && count($ips = $entity->getIpAddresses())) {
        $details = $ips->first()->getIpDetails();
        // Only update with IP details if none of the following are set to prevent wrong combinations
        if (empty($fields['core']['city']['value']) && empty($fields['core']['state']['value']) && empty($fields['core']['country']['value']) && empty($fields['core']['zipcode']['value'])) {
            if (!empty($details['city'])) {
                $entity->addUpdatedField('city', $details['city']);
                $companyFieldMatches['city'] = $details['city'];
            }


            if (!empty($details['region'])) {
                $entity->addUpdatedField('state', $details['region']);
                $companyFieldMatches['state'] = $details['region'];
            }

steverobinson · December 13, 2019, 5:54pm

Thanks for the code citation. I think I figured out what is happening, now I’m just concerned about how often it’s happening.

known contact has full address set in 123 Main St, Chicago, IL 63012
Anonymous contact visits web page from Cincinnati, OH
Anonymous contact fills out web form and becomes known, with same email as known contact
Contacts merge and resulting contact has address 123 Main St, Cincinnati, OH 63012.

Plausible? Does anyone know the rules for when two contacts merge which field values win?

steverobinson · December 13, 2019, 8:59pm

I created an issue in GitHub: https://github.com/mautic/mautic/issues/8233

I’m honestly not sure if this is a new bug or if it’s always been there. If it’s always been there, I’m not sure the best way to fix it.

Regardless, we have lots of issues with data integrity where an upload may contain city and state, but the record already has a full address and something inside of Mautic that would prevent a less complete address from ever updating a more complete address via merge or import would be a good thing in my mind.

Topic		Replies	Views
IP lookup whois setup Product Support	2	494	May 22, 2022
Updating a contact's Location after Maxmind database download Product Support	7	832	April 30, 2021
Ip Lookup service - Geolocation problems with Geoip2 Product Support	1	1356	May 21, 2023
GeoIP maxmind - no location infos Product Support	1	597	September 23, 2020
Contact randomly overwritten Product Support mautic-4	1	365	July 20, 2022

Has IP Lookup (e.g. maxmind) always overwritten location information? Any way to change this behavior?

Related topics