PluginBundleBase error

Development
1

These 2 bugs in PluginBundleBase break plugin install / update.



Simple fix: replace in line 36



self::onInstall($factory);

with

static::onInstall($factory);





and replace in line 99



self::onUpdate($addon, $factory);

with

static::onUpdate($addon, $factory);



More info here: http://php.net/manual/en/language.oop5.late-static-bindings.php#language.oop5.late-static-bindings.self

2

These 2 bugs in PluginBundleBase break plugin install / update.

Simple fix: replace in line 36

self::onInstall($factory);
with
static::onInstall($factory);

and replace in line 99

self::onUpdate($addon, $factory);
with
static::onUpdate($addon, $factory);

More info here: http://php.net/manual/en/language.oop5.late-static-bindings.php#language.oop5.late-static-bindings.self

3

Thanks for the code, but could you create a pull request with your changes so we could discuss it more comfortably?

https://github.com/mautic/mautic

When you do, please, describe what was the initial problem, what are the steps to recreate.

4

done

5

Thanks! Just to complete the information for others, the PR is here:

https://github.com/mautic/mautic/pull/1045